Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Added an optional HybridGlobalization run of libraries #95324

Merged
merged 28 commits into from
Dec 12, 2023
Merged

[browser] Added an optional HybridGlobalization run of libraries #95324

merged 28 commits into from
Dec 12, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Nov 28, 2023 •
edited
Loading

Fixes #95282.

Runs on:
- rolling build add it in a few weeks in a follow-up PR, when we decide that it is stable

  • on request as a part of: /azp run runtime-wasm-libtests

We have a few not supported operations, e.g. GetHashCode or Compare with certain sets of StringComparison options. Tests that use them were blocked. Some tests need further investigation, connected issues:
#95503
#95471
#95473
#95594
#95623

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm labels Nov 28, 2023
@ilonatommy ilonatommy self-assigned this Nov 28, 2023
@ghost
Copy link

ghost commented Nov 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #95282.

Runs on:

  • rolling build
  • on request: /azp run runtime-wasm-hg-tests
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Infrastructure-mono, os-browser
Milestone: -

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-hg-tests

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@ilonatommy
Copy link
Member Author

No pipelines are associated with this pull request.

@radical, am I missing something to be able to trigger the template's job?

@build-analysis build-analysis bot mentioned this pull request Nov 28, 2023
Closed
@radical
Copy link
Member

radical commented Nov 28, 2023

No pipelines are associated with this pull request.

@radical, am I missing something to be able to trigger the template's job?

You will need to ask FR to add a corresponding pipeline. Maybe add this to runtime-wasm-libtests?

This was referenced Nov 28, 2023
Open
Open
@radical
Copy link
Member

radical commented Nov 29, 2023

/azp run runtime-wasm-libtests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-libtests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-libtests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

Locally, running with node v20.8.0 WasmTestOnNodeJS-System.Globalization.Hybrid.WASM.Tests passes. Is it possible that Helix uses different node versions on Windows than on Linux? Window's logs are truncated - there's no info about version there.

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-libtests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-libtests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-libtests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-libtests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-libtests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy marked this pull request as ready for review December 11, 2023 09:16
radical
radical reviewed Dec 11, 2023
View reviewed changes
src/libraries/tests.proj
@@ -84,6 +84,12 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime\tests\System.Globalization.Tests\Hybrid\System.Globalization.Hybrid.WASM.Tests.csproj" />
</ItemGroup>

<!-- invariant project cannot be tested in hybrid mode; projects using functions that throw PNSE too often to block separate tests (HashCode, CompareOptions) -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projects using functions that throw PNSE too often to block separate tests (HashCode, CompareOptions)

  • can you explain this? And is there an issue for it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not an issue, it's by design, here is the doc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up job, I should add the APIs from tests that I blocked in this PR to the doc (into "Affected public APIs" sections).

radical
radical approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI related changes LGTM 👍

@ilonatommy @radical
Update src/libraries/Common/tests/Tests/System/StringTests.cs
7cc6538 
Co-authored-by: Ankit Jain <radical@gmail.com>
@ilonatommy ilonatommy merged commit f2a5fbf into dotnet:main Dec 12, 2023
120 of 123 checks passed
ilonatommy added a commit to ilonatommy/runtime that referenced this pull request Dec 12, 2023
@ilonatommy
Follow up for dotnet#95324
cc06c6f
@ilonatommy ilonatommy mentioned this pull request Dec 12, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@matouskozak matouskozak Awaiting requested review from matouskozak

@mkhamoyan mkhamoyan Awaiting requested review from mkhamoyan

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@kg kg Awaiting requested review from kg

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm] Create an optional job for HybridGlobalization on CI
3 participants
@ilonatommy @radical @matouskozak